Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Ox/direct-style-compatible OpenTelemetry tracing backend #2314

Open
adamw opened this issue Oct 16, 2024 · 13 comments
Open

Add an Ox/direct-style-compatible OpenTelemetry tracing backend #2314

adamw opened this issue Oct 16, 2024 · 13 comments

Comments

@adamw
Copy link
Member

adamw commented Oct 16, 2024

Currently sttp-client only ships with OT+ZIO tracing integration.

The goal of the issue is to create a new module, opentelemetry-tracing-sync-backend, which will provide integration with blocking/direct-style OpenTelemetry tracing, as well as reference documentation showcasing how to use the module.

Moreover, a first step is to suggest a way of propagating the context (setting appropriate headers, including identifiers/correlation ids) that is compatible with virtual threads & scoped values, as used by Loom and Ox. Note that the the OT Java libraries often rely on ThreadLocals, which are not Loom-compatible.

See also softwaremill/tapir#4103

@adamw
Copy link
Member Author

adamw commented Oct 16, 2024

/bounty $750

Copy link

algora-pbc bot commented Oct 16, 2024

💎 $1,000 bounty • SoftwareMill

Steps to solve:

  1. Start working: Comment /attempt #2314 with your implementation plan
  2. Submit work: Create a pull request including /claim #2314 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to softwaremill/sttp!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @varshith257 Nov 21, 2024, 1:50:35 PM WIP
🔴 @stdthoth Dec 6, 2024, 11:24:39 AM WIP

@varshith257
Copy link
Contributor

varshith257 commented Oct 16, 2024

Once #2292 is done I will jump here to tackle this.

@adamw
Copy link
Member Author

adamw commented Oct 21, 2024

As we are getting first PRs for the bounties, I've published our "How to prepare a good PR" guide. I should have probably done this right away, sorry! :)

@softwaremill softwaremill deleted a comment from SheebSuka Oct 31, 2024
@stdthoth
Copy link

Hey @adamw is this still available ?

@varshith257
Copy link
Contributor

varshith257 commented Nov 21, 2024

@stdthoth it's in WIP. Will raise PR soon
I think I have to push a PR so that others know I am working on it but just a few things need a fix and will draft PR

@adamw
Copy link
Member Author

adamw commented Nov 21, 2024

@stdthoth as long as a PR isn't merged it is available - I've setup attempts (with /attempt) to time out after two weeks, that could provide some indication. @varshith257 I don't think you've attempted this issue?

Anyway, the first (good!) PR to get merged wins :)

@varshith257
Copy link
Contributor

varshith257 commented Nov 21, 2024

I haven't attempted due to algora bot limits the attempts and I haven't done this to make sure not make any messy with algora bot 😀

Anyway /attempt #2314

Algora profile Completed bounties Tech Active attempts Options
@varshith257    1 softwaremill bounty
+ 19 bounties from 9 projects
Rust, Scala,
Go & more
Cancel attempt

Copy link

algora-pbc bot commented Nov 28, 2024

@varshith257: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏

Copy link

algora-pbc bot commented Dec 5, 2024

The bounty is up for grabs! Everyone is welcome to /attempt #2314 🙌

@stdthoth
Copy link

stdthoth commented Dec 6, 2024

/attempt #2314

Algora profile Completed bounties Tech Active attempts Options
@stdthoth 1 bounty from 1 project
Cancel attempt

Copy link

algora-pbc bot commented Dec 13, 2024

@stdthoth: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏

Copy link

algora-pbc bot commented Dec 20, 2024

The bounty is up for grabs! Everyone is welcome to /attempt #2314 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants