Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

선착순 이벤트 퀴즈 제출 최종 점검 #129

Merged
merged 23 commits into from
Aug 25, 2024
Merged

선착순 이벤트 퀴즈 제출 최종 점검 #129

merged 23 commits into from
Aug 25, 2024

Conversation

starwook
Copy link
Collaborator

연관된 이슈

작업 내용

스크린샷 (선택)

https://www.notion.so/bside/7d5a2e73a5c3431f8679d630060d84a6

starwook and others added 13 commits August 24, 2024 13:28
@starwook
feat: 선착순 퀴즈 제출때의 커넥션 할당을 위한 새로운 DataSource 설정 구현
f6cab54
@starwook
feat: 선착순 퀴즈 제출때의 커넥션 할당을 위한 Transaction Manager 구현
90a426e
@starwook
feat: 선착순 퀴즈 제출을 위한 DataSource와 Transactional 실제 Service에 적용
466752b
@starwook
refactor: 선착순 퀴즈 제출을 위한 DataSource ConnectionTimeOut 최소값으로 수정
9f7ae21
@starwook
refactor: HikariConfig 설정 수정
bf51206 
[- url, username, password 설정 방식 수정]
@starwook
refactor: 기본 DataSource가 빈으로 등록 되도록 구현
b450b3d
@starwook
feat: OrderResultSaveService가 다른 DataSource를 주입받는지 확인하는 테스트 구현
a482a4e
@starwook
feat: DataSource 분리 구현
8267dfa 
[- Order 도메인 중에서 퀴즈제출과 관련된 OrderResult,OrderApplyCount 분리.
- 다른 테이블과 결합도가 적음]
@starwook
refactor: 퀴즈 정답 제출시 OrderResult용 HikariDataSource를 쓰도록 수정
01faa50
@starwook
refactor: DataSource관련 설정 파일이 테스트 환경에서 등록되지 않도록 수정
e0c2637
@starwook
refactor: 통합 테스트가 언제나 local.yml환경에 의지하도록 수정
67146bd
@starwook
refactor: 별개의 트랜잭션 매니저가 필요한 메소드 주석으로 수정
9ee0f68 
[- 추후 구현]
@starwook
Merge branch 'dev' into WB-284-api-server
29a9ef7
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

Unit Test Results

  37 files    37 suites   11s ⏱️
149 tests 149 ✔️ 0 💤 0 ❌
150 runs  150 ✔️ 0 💤 0 ❌

Results for commit d04e530.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

3 similar comments
@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@starwook
refactor: 선착순 이벤트 퀴즈 제출시 커넥션을 얻지 못 했을 때의 에러 명시와 , 반환값 수정
7516a0c 
[- 선착순 이벤트 퀴즈 제출 메소드에서 커넥션을 얻지 못할때의 에러(CannotCreateTransactionException)를 명확하게 표기하도록 수정
- 커넥션을 얻었지만 선착순 인원이 꽉 찼을 시에도 바로 값을 반환하여 커넥션을 다시 얻으려하는 시도가 없도록 수정]
@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

3 similar comments
@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@starwook
refactor: 선착순 이벤트 퀴즈 제출시 커넥션을 얻으려고 하는 횟수 수정
16471e2 
[- 250ms 5번 1.25초 -> 250ms 120번 -> 30초(디폴트값)]
@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

1 similar comment
@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

1 similar comment
@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

1 similar comment
@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

1 similar comment
@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

1 similar comment
@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

ysndy
ysndy approved these changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@ysndy ysndy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@ysndy ysndy merged commit 09b2321 into dev Aug 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysndy ysndy ysndy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@starwook @ysndy