Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY] - referencing new standardize pr comment for event url #621

Merged
merged 1 commit into from
Sep 25, 2023
Merged

[READY] - referencing new standardize pr comment for event url #621

merged 1 commit into from
Sep 25, 2023

Conversation

sarcasticadmin
Copy link
Member

@sarcasticadmin sarcasticadmin commented Sep 25, 2023 •
edited
Loading

Description of PR

Fixes annoying failing comments in any issue.

Previous Behavior

  • Issue comment triggers a GHA that fails

New Behavior

  • Issue comments are skipped correctly correct in GHA (but still run due to how actions)

Tests

@sarcasticadmin
Copy link
Member Author

/tux openwrt flash test-one-2

@github-actions
Copy link

[RUNNING] - Successfully triggered gitlab flash pipeline:

sarcasticadmin
sarcasticadmin commented Sep 25, 2023
View reviewed changes
.github/workflows/trigger.yml
@@ -16,7 +16,7 @@ jobs:
steps:
- name: Standardize PR comment
id: pr-standardize-comment
uses: nebulaworks/[email protected]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tux openwrt flash test-one-2

@github-actions
Copy link

[RUNNING] - Successfully triggered gitlab flash pipeline:

@sarcasticadmin sarcasticadmin changed the title [WIP] - referencing new standardize pr comment for event url [READY] - referencing new standardize pr comment for event url Sep 25, 2023
kylerisse
kylerisse approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@kylerisse kylerisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this seems to make sense sarcasticadmin/action-standardize-pr-comment@bc2d905
Thanks @sarcasticadmin , lets see how it goes!

@kylerisse kylerisse merged commit f0647c0 into master Sep 25, 2023
7 checks passed
@kylerisse kylerisse deleted the rh/1695638315ghboken branch September 25, 2023 12:19
@sarcasticadmin sarcasticadmin mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylerisse kylerisse kylerisse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarcasticadmin @kylerisse