Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output did not contain correct version #14

Open
mrmodolo opened this issue Oct 4, 2021 · 2 comments
Open

output did not contain correct version #14

mrmodolo opened this issue Oct 4, 2021 · 2 comments

Comments

@mrmodolo
Copy link

mrmodolo commented Oct 4, 2021

Hi!

The latest update no longer allows updating binaries!

I found that binaries in '~/.loki-shell/bin/' no longer show version as expected:

for f in .loki-shell/bin/*; do $f --version; done;
logcli, version  (branch: , revision: )
  build user:       
  build date:       
  go version:       go1.16.2
  platform:         linux/amd64
loki, version  (branch: , revision: )
  build user:       
  build date:       
  go version:       go1.16.2
  platform:         linux/amd64
promtail, version  (branch: , revision: )
  build user:       
  build date:       
  go version:       go1.16.2
  platform:         linux/amd64

I had to change the check_binary function in the install file to ignore the version and be able to install the binaries.

Regards,
Marcelo Módolo

@mrmodolo
Copy link
Author

mrmodolo commented Oct 4, 2021

Hi!

I found that the problem is with the output of binaries with the '--version' option in the 2.3.0 release

with 2.2.1
./loki-linux-amd64 --version
loki, version 2.2.1 (branch: HEAD, revision: babea82e)
  build user:       root@e2d295b84e26
  build date:       2021-04-06T00:52:41Z
  go version:       go1.15.3
  platform:         linux/amd64

with 2.3.0  
./loki-linux-amd64 --version
loki, version  (branch: , revision: )
  build user:       
  build date:       
  go version:       go1.16.2
  platform:         linux/amd64  

Regards,

Marcelo Módolo

@slim-bean
Copy link
Owner

Ahh, good cactch @mrmodolo and thanks for reporting. I believe we fixed this in Loki 2.4.0, gonna do some updating myself today and I'll make sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants