Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sensor state values from translation #384

Open
ChristophCaina opened this issue Dec 2, 2024 · 2 comments
Open

remove sensor state values from translation #384

ChristophCaina opened this issue Dec 2, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ChristophCaina
Copy link

The myskoda integration is using translation for sensor values, which are also translated by default within HomeAssistant.
Example: Device_Tracker -> "home" == "Anwesend" (de.json) or several Binary_sensors.

Therefore, the translation is in some areas not consistent with the translation provided by HomeAssistant itself for such values.

The Integration should only provide translated values, when HomeAssistant does not provide a valid / usefull translation for a sensor, whenever possible, the translation should use the default translation provided by HomeAssistant.

@WebSpider
Copy link
Contributor

Feel free to submit a PR to improve this.

@WebSpider WebSpider added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 2, 2024
@dvx76 dvx76 added the enhancement New feature or request label Dec 3, 2024
@WebSpider
Copy link
Contributor

I've had a go at this when first starting with translations and have not found a good way (or example) to marry the core translations and custom integration translations successfully.

If someone has an example that works, or a PR that does this, that would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants