From 2569b472575a2c39db1edd1f8d40e9c5ad4290d9 Mon Sep 17 00:00:00 2001
From: nadimabdelaziz <nadeem.abdelaziz99@gmail.com>
Date: Tue, 17 Dec 2024 22:22:11 -0800
Subject: [PATCH] cleanup

---
 .github/workflows/e2e.yml | 2 +-
 .gitignore                | 6 +++---
 Makefile                  | 4 ++--
 README.md                 | 2 ++
 tests/e2e/e2e_test.go     | 3 +--
 5 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
index 14ca859..acbc207 100644
--- a/.github/workflows/e2e.yml
+++ b/.github/workflows/e2e.yml
@@ -48,7 +48,7 @@ jobs:
         run: |
           make tidy
           git submodule update --init --recursive
-          cd tests/e2e/lib/openzeppelin-contracts && git checkout v4.8.0
+          cd tests/e2e/lib/openzeppelin-contracts && git checkout v4.8.0 // this matches the dependency version in hyperlane
           cd ../openzeppelin-contracts-upgradeable && git checkout v4.8.0
           cd ../hyperlane-monorepo/solidity && yarn install --frozen-lockfile
           cd ../../../../.. && make e2e-test
diff --git a/.gitignore b/.gitignore
index 9ec4a39..0c6866d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,8 +5,8 @@ keys.json.plaintext
 solver.db
 vendor
 .idea
-out
-cache
-broadcast
 config/local/config.yml
 config/local/keys.json
+out
+broadcast
+cache
\ No newline at end of file
diff --git a/Makefile b/Makefile
index 31740a3..48adafc 100644
--- a/Makefile
+++ b/Makefile
@@ -46,8 +46,8 @@ setup-foundry:
 		foundry-rs/forge-std \
 		OpenZeppelin/openzeppelin-contracts@v4.8.0 \
 		OpenZeppelin/openzeppelin-contracts-upgradeable@v4.8.0 \
-		hyperlane-xyz/hyperlane-monorepo \
-		--no-commit
+		hyperlane-xyz/hyperlane-monorepo --no-commit \
+		&& cd lib/hyperlane-monorepo/solidity && yarn install --frozen-lockfile
 
 .PHONY: e2e-test
 e2e-test:
diff --git a/README.md b/README.md
index 502d9a8..ccfc248 100644
--- a/README.md
+++ b/README.md
@@ -68,6 +68,8 @@ docker run skip-go-fast-solver
 
 ```shell
 make unit-test
+
+make setup-foundry # install end to end test dependencies
 make e2e-test
 ```
 
diff --git a/tests/e2e/e2e_test.go b/tests/e2e/e2e_test.go
index 6faa2bf..c267803 100644
--- a/tests/e2e/e2e_test.go
+++ b/tests/e2e/e2e_test.go
@@ -115,7 +115,7 @@ func (s *SolverTestSuite) SetupSuite(ctx context.Context) {
 
 		s.Require().NoError(err, fmt.Sprintf("error deploying contracts: \nstderr: %s\nstdout: %s\nerr: %s", stderr, stdout, err))
 
-		// deploy Hyperlane contracts with a different set of remappings
+		// deploy hyperlane contracts with a different set of remappings
 		hyperlaneDeployOutput, stderr, err := eth.ForgeScript(ctx, s.deployer.KeyName(), ethereum.ForgeScriptOpts{
 			ContractRootDir:  "./tests/e2e",
 			SolidityContract: "scripts/HyperlaneTestDeploy.s.sol:HyperlaneTestDeploy",
@@ -179,7 +179,6 @@ func (s *SolverTestSuite) TestDeploy() {
 	s.SetupSuite(ctx)
 
 	s.Require().True(s.Run("Verify deployment", func() {
-		// Verify that the contracts have been deployed
 		s.Require().True(s.Run("Verify ERC20 Genesis", func() {
 			userBalance, err := s.erc20Contract.BalanceOf(nil, crypto.PubkeyToAddress(s.key.PublicKey))
 			s.Require().NoError(err)