Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting when svgo.json is broken #23

Open
bomberstudios opened this issue Jul 31, 2017 · 3 comments
Open

Improve error reporting when svgo.json is broken #23

bomberstudios opened this issue Jul 31, 2017 · 3 comments

Comments

@bomberstudios
Copy link
Contributor

See #21 for background info

@bomberstudios bomberstudios self-assigned this Jul 31, 2017
@davemoz
Copy link

davemoz commented Nov 21, 2017

+1 for this.

I edited the json settings file once yesterday(only commented out one option), and today when I select "About SVGO Compressor" nothing happens :/ Would love to know more details about whether the file is broken or not.

@mathieudutour
Copy link
Contributor

mathieudutour commented Nov 21, 2017

JSON doesn't support comments so you can't comment out a field. So i'd say the file is broken :)

@davemoz
Copy link

davemoz commented Nov 21, 2017

Ah, thanks! Changed it back and it's working. I guess this still applies to this issue though. More details when something is wrong, instead of simply not responding, would help diagnose the problem. Thanks again!

@bomberstudios bomberstudios removed their assignment Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants