Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Bug in Grails GWT Plugin #53

Open
confile opened this issue Mar 23, 2014 · 3 comments
Open

Security Bug in Grails GWT Plugin #53

confile opened this issue Mar 23, 2014 · 3 comments

Comments

@confile
Copy link

confile commented Mar 23, 2014

I found a security bug in this plugin. The output ouf this plugin is compiled to the grails projects

web-app 
> gwt

folder. The gwt folder contains the following folders:

> yourprojectname
> WEB-INF

The WEB-INF folder should not be accessible from a browser. It turns out it is. You can access files which are inside this folder.

This should be fixed.

@bwolff
Copy link

bwolff commented Apr 5, 2014

This folder is created by the GWT compiler because usually it assumes to work in the web-app root, so the WEB-INF stuff will be put in the correct folder, thus disabling access to the files.

Anyway, I think the WEB-INF folder created by GWT only contains some "deploy" files that can be quite big and usually do nothing more than bloating up the WAR file. Usually I put some code in the _Event.groovy file that is executed before the WAR file is created and delete this extra WEB-INF folder.

So I'm not sure if this folder can be "disabled" via GWT compiler parameters. Otherwise the output folder for the GWT resources would have to be reconfigured, which would also change the links under which they are available.

Cheers,
Ben

@confile
Copy link
Author

confile commented Apr 6, 2014

@daviddawson What do you think on this issue?

@confile
Copy link
Author

confile commented May 12, 2014

@daviddawson Could you please comment on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants