Beacon block streamer test fails on macOS in debug mode

[alecalve]

Description

This is happening on a MacBook pro.

Version

Lighthouse: v6.0.0
Cargo: cargo 1.82.0 (8f40fc59f 2024-08-21)
Rustup:

active toolchain
----------------

stable-aarch64-apple-darwin (default)
rustc 1.82.0 (f6e511eec 2024-10-15)

Present Behaviour

Initial setup:

git clone [email protected]:sigp/lighthouse.git lighthouse-repro
cd lighthouse-repro
git checkout v6.0.0

First failing test

Link to code

Command:

cargo test --package beacon_chain --lib -- data_availability_checker::overflow_lru_cache::test::overflow_cache_test_state_cache --show-output

Output:

    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.91s
     Running unittests src/lib.rs (target/debug/deps/beacon_chain-d9a1d435f251ff26)

running 1 test

thread 'tokio-runtime-worker' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p beacon_chain --lib`

Second failing test

Link to code

Command:

cargo test --package beacon_chain --lib -- beacon_block_streamer --show-output

Output:

    Finished `test` profile [unoptimized + debuginfo] target(s) in 1.02s
     Running unittests src/lib.rs (target/debug/deps/beacon_chain-d9a1d435f251ff26)

running 1 test

thread 'tokio-runtime-worker' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p beacon_chain --lib`

Expected Behaviour

The tests should complete.

[michaelsproul]

Duplicate of:

• stack overflow when running overflow_cache_test_state_cache in debug #6120

We are fighting a constant battle against stack overflows in debug mode, because the Rust compiler has a hard time optimising the nested function calls + futures in some of our deps (esp warp).

Running the tests in --release is the recommended approach, see make test-release which is what runs on CI.

[michaelsproul]

Realised there's a second failing test there in the beacon_block_streamer, which is not identified in the other issue. I'll leave this one open to track that.