Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate type for unaggregated network attestations #6380

Open
3 tasks
eserilev opened this issue Sep 10, 2024 · 0 comments
Open
3 tasks

Separate type for unaggregated network attestations #6380

eserilev opened this issue Sep 10, 2024 · 0 comments
Assignees
Labels
electra Required for the Electra/Prague fork v6.1.0 New release c. Q1 2025

Comments

@eserilev
Copy link
Collaborator

eserilev commented Sep 10, 2024

Description

Introduces a SingleAttestation type that helps differentiate between unaggregated and aggregated attestations during network processing>

Spec: ethereum/consensus-specs#3900

We'll probably want to implement this change in two or three stages:

  • Add new SingleAttestation gossip topic. When receiving SingleAttestation objects over gossip, immediately convert to Attestation to reduce implementation complexity. This needs to be included before Electra. SingleAttestation implementation #6488
  • Full implementation of SingleAttestsation. Don't convert it to a Attestation so that we reap the full benefits of the SingleAttestation changes. This can optionally be included before Electra. SingleAttestation refactor #6616
  • Unify GossipAttestation and GossipSingleAttestation flows. This entails immediately converting Attestations received over gossip into SingleAttestations. This allows us to delete a bunch of code. This should probably only be included post Electra.
@eserilev eserilev added the electra Required for the Electra/Prague fork label Sep 10, 2024
@eserilev eserilev self-assigned this Sep 10, 2024
@realbigsean realbigsean added the v6.1.0 New release c. Q1 2025 label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electra Required for the Electra/Prague fork v6.1.0 New release c. Q1 2025
Projects
None yet
Development

No branches or pull requests

2 participants