Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement _meta.ts Type safe #3736

Open
Tracked by #2600
nikischin opened this issue Nov 24, 2024 · 2 comments
Open
Tracked by #2600

Implement _meta.ts Type safe #3736

nikischin opened this issue Nov 24, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@nikischin
Copy link

nikischin commented Nov 24, 2024

Is your feature request related to a problem? Please describe.
I would like to add type safety to _meta.ts just like for theme.config.tsx so I see if I typed the correct configurations.

Describe the solution you'd like
Add a type to the exported meta config object just like in the theme.config.tsx

Describe alternatives you've considered

Additional context
v3

@nikischin nikischin added the enhancement New feature or request label Nov 24, 2024
@dimaMachina
Copy link
Collaborator

this kinda is improved in v4, because I did setup of parsing/normalizing _meta files on server, so in case you have a typo - you'll have a runtime error, but we can export MetaRecord type as well!

@dimaMachina dimaMachina mentioned this issue Nov 25, 2024
52 tasks
@nikischin
Copy link
Author

this kinda is improved in v4, because I did setup of parsing/normalizing _meta files on server, so in case you have a typo - you'll have a runtime error, but we can export MetaRecord type as well!

Sounds like exporting MetaRecord would be an easy fix, even for v3? While I will love to migrate to v4 soon, I think for those still on v3 it would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants