Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShareDB CI Breakage #147

Open
curran opened this issue Mar 3, 2023 · 1 comment
Open

ShareDB CI Breakage #147

curran opened this issue Mar 3, 2023 · 1 comment

Comments

@curran
Copy link
Contributor

curran commented Mar 3, 2023

The ShareDB CI pipeline seems impacted by recent changes here, as evidenced by this PR:

share/sharedb#599

The output there reads:

Run scripts/test-sharedb-mongo.sh
Cloning into 'sharedb-mongo'...
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected].[4](https://github.com/share/sharedb/actions/runs/4323100701/jobs/7546300118#step:9:5)
npm ERR! node_modules/sharedb
npm ERR!   sharedb@"file:../sharedb" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer sharedb@"^1.0.0-beta || ^2.0.0" from [email protected]
npm ERR! node_modules/sharedb-mingo-memory
npm ERR!   dev sharedb-mingo-memory@"^1.1.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/runner/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-03-03T11_47_[5](https://github.com/share/sharedb/actions/runs/4323100701/jobs/7546300118#step:9:6)8_0[7](https://github.com/share/sharedb/actions/runs/4323100701/jobs/7546300118#step:9:8)2Z-debug-0.log

It looks like to do with

Proposed fix

I would guess that upgrading the sharedb-mingo-memory version here would solve the issue.

Also, for the sake of stability, it may be worth having ShareDB's scripts/test-sharedb-mongo.sh use a specific commit of this repository, as currently the CI of ShareDB is vulnerable to changes in this repo because that script always pulls the latest from here.

Cheers!

This was referenced Mar 3, 2023
@alecgibson
Copy link
Contributor

I don't think this is the reason for the failing build, although we should deal with the dependency issue. The actual failure in the test suite is this issue: #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants