Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume all Knative installations use Istio #1

Open
bbrowning opened this issue Nov 15, 2019 · 1 comment
Open

Do not assume all Knative installations use Istio #1

bbrowning opened this issue Nov 15, 2019 · 1 comment

Comments

@bbrowning
Copy link
Contributor

This is related to serverless/serverless-knative#2 but there are code changes required in both repos to fix this.

Not all Knative installations use Istio and even for the ones that do not all of them use the istio-ingressgateway service name, the istio-system namespace, nor do all of them give the Istio ingressgateway a public IP.

@rhuss
Copy link
Contributor

rhuss commented Mar 6, 2020

Anything I can do to help to solve this issue ?

E.g. I managed to play through the Knative demo with minikube on my local machine, but broke at this point (because on minikube the istio setup is different, e.g. doesn't use a loadbalancer).

I think we can be much more flexible here and need to detect the api gateway in use, and react flexibly depending on the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants