Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.test can never be red #638

Open
hhowe29 opened this issue Mar 11, 2023 · 0 comments · May be fixed by #640
Open

build.test can never be red #638

hhowe29 opened this issue Mar 11, 2023 · 0 comments · May be fixed by #640

Comments

@hhowe29
Copy link

hhowe29 commented Mar 11, 2023

Assertion errors need to be passed to the mocha done callback, otherwise the test will appear to be green.

These lines should be changed to

    auto.build().then(tableData => {
      callback(tableData);
      done();
    }).catch((e) => {
      done(e);
    })
hhowe29 pushed a commit to hhowe29/sequelize-auto that referenced this issue Mar 11, 2023
Make assertion errors in build.test fail the test if they occur. Trea…
e410a5c 
…t single column unique indexes as a primary key if no other primary key was found. Fixes sequelize#638 and implement sequelize#639.
hhowe29 added a commit to hhowe29/sequelize-auto that referenced this issue Mar 11, 2023
@hhowe29
Make assertion errors in build.test fail the test if they occur. Trea…
0782d9d 
…t single column unique indexes as a primary key if no other primary key was found. Fixes sequelize#638 and implement sequelize#639.
@hhowe29 hhowe29 linked a pull request Mar 11, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #638 and #639: treat single column unique indexes as primary key hhowe29/sequelize-auto
1 participant
@hhowe29