Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why aren't the pull requests being reviewed? #265

Open
nloyola opened this issue Nov 25, 2015 · 12 comments
Open

Why aren't the pull requests being reviewed? #265

nloyola opened this issue Nov 25, 2015 · 12 comments

Comments

@nloyola
Copy link

nloyola commented Nov 25, 2015

Is someone in charge of this project? Can we get some feedback on when the pull requests will be reviewed and acted on?

@kleewho
Copy link
Collaborator

kleewho commented Nov 25, 2015

I can speak only for myself. My desire to code after hours is quite low and that is the reason I'm so silent lately. I'll rearrange some things in my day week schedule and let's see how that will work out for me. Maybe I find some time. I can't promise anything more then I'll try.

Of course, if someone is interested in helping maintaining it's good idea to be around, evaluate changes in PRs and give some feedback. Write some tests maybe. It's always good to have larger test suite. I'm more confident when merging.

@nloyola
Copy link
Author

nloyola commented Nov 25, 2015

I interested in helping. I started writing tests 2 weeks ago, but then gave up since I never received any comments back on my pull requests. I can add another pull requests with the tests I have so far.

@ghost
Copy link

ghost commented Nov 25, 2015

@kleewho @nloyola Thank you for all the developers of the emacs-eclim, I hope this package will keepalive

@kleewho
Copy link
Collaborator

kleewho commented Dec 1, 2015

@nloyola please do that

@gopar
Copy link

gopar commented Dec 16, 2015

Didn't someone mentioned about the possibility of making this into a team account project?

@kleewho
Copy link
Collaborator

kleewho commented Dec 16, 2015

@gopar @nloyola @zwb-ict I'm doing it right now. It's pointless to keep the situation like we have right now. I'll post all details shortly (give me a two days to set it up and to think what else needs to be changed)

@nloyola
Copy link
Author

nloyola commented Dec 16, 2015

Thank you @kleewho.

@kleewho
Copy link
Collaborator

kleewho commented Dec 16, 2015

Hell you can all figure out what needs to be done. I made @jchochli, @nloyola, @gopar administrators there although @jchochli was even more silent then I was. I hope that with new ppl that are actually using emacs-eclim the situation with stalled pull requests will go away.

What definitely needs to be done is this https://github.com/milkypostman/melpa/blob/b9faeb6d910d686cbcafe7d12e0bcf62a85689bd/recipes/emacs-eclim.

Organization is here https://github.com/emacs-eclim and the repo here https://github.com/emacs-eclim/emacs-eclim. I send invitations to organization as well so there's a chance that more acctive users will be in charge of this project.

@nloyola
Copy link
Author

nloyola commented Dec 16, 2015

Thanks so much for doing this @kleewho. I'll push my changes soon.

@jchochli
Copy link
Collaborator

@kleewho thanks, i am lurking and would still like to contribute.

@kleewho
Copy link
Collaborator

kleewho commented Dec 16, 2015

And you're still able too cause you're an admin ;)

śr., 16 gru 2015, 20:20 James Chochlinski użytkownik <
[email protected]> napisał:

@kleewho https://github.com/kleewho thanks, i am lurking and would
still like to contribute.


Reply to this email directly or view it on GitHub
#265 (comment).

@dgutov
Copy link
Contributor

dgutov commented Dec 24, 2015

Congrats on moving forward! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants