Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addTo method of attr.js should throw an error if it attempts to override an existing method or attribute in the class #24

Open
semmypurewal opened this issue Oct 28, 2012 · 0 comments

Comments

@semmypurewal
Copy link
Owner

This isn't happening yet because of our approach to implementing inheritance and making the instanceof operator work. We set the prototype to an instance of the super-model but then override each individual attribute with an actual cloned attribute. This is necessary to maintain encapsulation of the attribute.

We'll have to re-think our approach slightly to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant