-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing releases? #15
Comments
Code changes should be minimal (if any). As licensing changed and we move closer to GM with live/filters/signals, it was necessary that we remove all prior versions. I apologize in advance for any broken builds in the meantime. |
Hello @bsneed , I appreciate the update, but I respectfully have to point out that this approach is neither ideal nor technically correct. Removing previously released versions without following a deprecation process can cause significant issues, particularly for companies that rely on these libraries for their production environments. When prior versions are removed abruptly: Builds across CI pipelines break unexpectedly, causing unnecessary downtime and delays. If licensing changes required this move, I suggest reintroducing the missing versions as deprecated, clearly communicating the timeline for their removal. This would provide a grace period for teams to adapt and avoid widespread build failures. Please let us know if there’s a way to address this issue quickly in the interim while ensuring such actions are handled more smoothly in the future. Thank you for understanding the impact this has on the developer community. Best regards, |
@sadaf-behbahani I understand your frustration. This was previously a pilot library and no guarantees of support are made on that tier of libraries unfortunately. While it's not my favorite thing to do, it was required by our legal counsel. I understand how software development works and the impacts that can be associated and have been at it for over 30 years now. It pained me to have to do that, but as you can probably attest to as a Segment customer, it's not the norm. I can only remember a single time it's happened elsewhere in the 6 years I've been here. |
As always, I'm here to help. If anyone following this thread runs into issues, I'll move heaven and earth to get you going ASAP. |
Thank you @bsneed for your answer, we are currently facing issues. What would unblock us, is analytics-swift-filters to be updated to refer to the latest version of this library analytics-swift-live |
@PhilippeTouchTunes I'm on it! Stay tuned. |
Thank you for your response and taking the necessary actions to help us out. I understand that this wasn’t an easy call to make, and I appreciate your willingness to acknowledge the frustration this situation has caused. |
Ok, I've just pushed up analytics-swift-filters 0.1.2. I verified in the example app that no code changes were required for it to re-export analytics-swift-live. I also made mention in the readme that it's now deprecated. Is anyone available to try it out? |
@sadaf-behbahani I'm going to close the other issue you created since we're discussing here and this one has been reopened. |
@bsneed thank you , yes we are testing on our side, we will keep you updated |
FYI, another customer and I spotted a difference in startup for the old version vs. the new version. With the old one, if LivePlugins() wasn't already added, DestinationFilters() would add it. The current version, this does not happen. If using 3.1.0, you can fix this by doing ..
Alternatively, I'm going to adjust this in 3.1.1 where if LivePlugins is not present, DestinationFilters will add it like it used to. |
Analytics-swift-fitlers 0.1.3, which pulls analytics-swift-live 3.1.1 is now available which fixes the compatibility issue described in my previous comment. |
Hello @bsneed, Looks like depending on For prosperity here are the modifications we've done to fix our CI pipeline:
Thank you very much for your speedy assistance |
You're very welcome @Ferdzz ! I'm gonna leave this issue open for a bit to see if anyone else has trouble, but it seems we came to a solution. Thanks to you, @sadaf-behbahani and @PhilippeTouchTunes for all your assistance in getting this resolved! |
Moving further conversation to #18 |
Hello @bsneed, it seems some releases have gone missing.
analytics-swift-filters 0.1.1 (latest release) refers to this repo as a dependency with
.package(url: "https://github.com/segment-integrations/analytics-swift-live.git", .upToNextMajor(from: "0.2.3"))
. But any version matching this no longer exists here. It used to resolve to a 0.2.5 release.Xcode therefore fails to resolve the dependencies:
Were some releases accidentally deleted?
The text was updated successfully, but these errors were encountered: