Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoration choice of "Create new backup" or "Reuse" can be bypassed #789

Open
t-m-w opened this issue Oct 31, 2024 · 5 comments
Open

Restoration choice of "Create new backup" or "Reuse" can be bypassed #789

t-m-w opened this issue Oct 31, 2024 · 5 comments
Labels
Milestone

Comments

@t-m-w
Copy link
Collaborator

t-m-w commented Oct 31, 2024

The intended behavior is to ask the user the question about whether they want to create a new backup or reuse the existing backup, until they choose. Currently, it can be bypassed.

  1. Restore a backup.
  2. When asked the question, either press the Back button if you're in the Setup Wizard, or close Seedvault (swipe it out of Overview/Recents).
  3. Open Seedvault again.
  4. Turn on backups.
  5. Choose Backup Now.

Expected result: At some point after step 2, you must make the choice.

Actual result: You never need to make the choice. The backup proceeds anyway.

@grote
Copy link
Collaborator

grote commented Oct 31, 2024

Wait, so you started by restoring a backup? from SUW? Then, the question shouldn't be asked at all, especially not in SetupWizard.

@grote grote added the bug label Oct 31, 2024
@grote grote added this to the Roadmap milestone Oct 31, 2024
@t-m-w
Copy link
Collaborator Author

t-m-w commented Oct 31, 2024

Wait, so you started by restoring a backup? from SUW? Then, the question shouldn't be asked at all, especially not in SetupWizard.

Yes, but then when should it be asked? I've thought before that it may make more sense to ask when the user turns on backups.

@grote
Copy link
Collaborator

grote commented Oct 31, 2024

Ah I confused the special re-use screen and the dialog that comes up when starting a new installation of seedvault for the first time. You are talking about that entire re-use backup screen, right?

Where do you land when pressing the back button there?

I guess the observed behavior is alright. Closing or backing our is equivalent to not re-using. Safer course of action.

@t-m-w
Copy link
Collaborator Author

t-m-w commented Oct 31, 2024

You are talking about that entire re-use backup screen, right? Where do you land when pressing the back button there?

Yes. I end up back at the Setup Wizard's page that asks if I want to restore a backup at all, and I can just Skip that.

@grote
Copy link
Collaborator

grote commented Nov 1, 2024

ok, then I guess it is ok that this page can be skipped and what you saw is the expected behavior after all? case closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants