Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic error in transforming datetime columns using HyperTransformer #299

Open
avsolatorio opened this issue Jan 25, 2023 · 0 comments · May be fixed by #300
Open

Semantic error in transforming datetime columns using HyperTransformer #299

avsolatorio opened this issue Jan 25, 2023 · 0 comments · May be fixed by #300
Labels
bug Something isn't working new Label applied to new issues

Comments

@avsolatorio
Copy link

The snippet below should be something like: data[field] = pd.Series(integers, data.index).

SDMetrics/sdmetrics/utils.py

Line 199 in c996749

data[field] = pd.Series(integers)

As currently implemented, the transformed data will incorrectly map the values to the wrong data if the index in data is not the same as the default index in pd.Series.
@avsolatorio avsolatorio added bug Something isn't working new Label applied to new issues labels Jan 25, 2023
@avsolatorio avsolatorio linked a pull request Jan 25, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working new Label applied to new issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix datetime transform indexing issue avsolatorio/SDMetrics
1 participant
@avsolatorio