Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gretel] Optimize config and training parameters for gretel-synthetics #142

Open
zredlined opened this issue May 13, 2022 · 1 comment
Open
Labels
feature request Request for a new feature under discussion Issue is currently being discussed

Comments

@zredlined
Copy link

Problem Description

Some of the parameters in the gretel-synthetics implementation in SDGym can cause the model to fail during evaluation, and can be optimized for generating synthetic data (details below).

Expected behavior

In sdgym/synthesizers/gretel.py there are a few updates I'd recommend making:

  • Add learning_rate as a parameter, set default to 0.001 as per Gretel docs.
  • Add field_cluster_size as a tunable parameter
  • on batcher.generate_all_batch_lines, set a default max_invalid. For larger datasets, the default value of 1000 can cause the model to unnecessarily terminate and during sampling.
  • epochs can be set to a standard value (e.g. 100), no need to set epochs based on the number of columns. Early stopping and a validation set can be used to prevent overfitting.

Additional context

I'm happy to submit a PR with fixes and to compare against baseline config for tests, let me know if this would be okay. Cheers!

@zredlined zredlined added feature request Request for a new feature under discussion Issue is currently being discussed labels May 13, 2022
@katxiao
Copy link
Contributor

katxiao commented May 18, 2022

Hi @zredlined, thanks for taking a look at the Gretel implementation in SDGym! Please feel free to submit a PR with the updates you have proposed. You can link it to this issue and we'll be happy to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature under discussion Issue is currently being discussed
Projects
None yet
Development

No branches or pull requests

2 participants