Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate_resharding_after_refresh misusing follow_system_log #7133

Closed
fruch opened this issue Jan 22, 2024 · 1 comment
Closed

validate_resharding_after_refresh misusing follow_system_log #7133

fruch opened this issue Jan 22, 2024 · 1 comment
Assignees

Comments

@fruch
Copy link
Contributor

fruch commented Jan 22, 2024

this functions is doing a call like that:

resharding_logs = list(system_log_follower)

and expects the log line to be available right after that line.

that is not how the iterator give from follow_system_log should be use,
it should be read again and again in a loop until we get what we expect or timeout

we should introduce a helper function, or a method on this iterator, to be able to achieve that, with a timeout
and look for more naive usages of follow_system_log and address them

Ref: #4341

@fruch fruch assigned k0machi and unassigned fruch Jan 22, 2024
@fruch
Copy link
Contributor Author

fruch commented Mar 7, 2024

looks like this issue is incorrect, and failure cause of this are related to other issue, and should be investigated

@fruch fruch closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants