From 9438a5df5bdd7eb4ca8848afd89b18b8b5f2b5bc Mon Sep 17 00:00:00 2001 From: Liapkovich Date: Wed, 6 Nov 2024 15:34:25 +0100 Subject: [PATCH] fix(_rotate_kms_key): remove SkipPerIssues since the ticket is resolved As per discussion, this clause can be removed as the ticket is resolved and doesn't have sct skip label (what could have made it being skipped). At the same, it led to unexpected failures when self.params appeared to be dict type instance instead of SCTConfiguration as expected. refs: - https://github.com/scylladb/scylla-cluster-tests/issues/9134 (cherry picked from commit b9708e84fbe2cdf4ffb3c41873a9b206f861168c) --- sdcm/cluster.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/sdcm/cluster.py b/sdcm/cluster.py index ce16b34e2e..a4ae004f1f 100644 --- a/sdcm/cluster.py +++ b/sdcm/cluster.py @@ -4430,9 +4430,6 @@ def _rotate_kms_key(kms_key_alias_name, kms_key_rotation_interval, db_cluster): AwsKmsEvent( message=f"Failed to rotate AWS KMS key for the '{kms_key_alias_name}' alias", traceback=traceback.format_exc()).publish() - if SkipPerIssues("https://github.com/scylladb/scylla-enterprise/issues/3896", self.params): - self.log.warning("KMS encryption check is skipped due to the 'scylla-enterprise/issues/3896'") - continue try: nemesis_class = self.nemesis[0] if self.nemesis else getattr( import_module('sdcm.nemesis'), "Nemesis")