Ecall demo with Keccak-f #717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 5, 2024 14:50
This was
linked to
issues
Dec 10, 2024
Ecall keccak (merge resolution)
Dummy circuit for large ecalls
|
@kunxian-xia Merged all recent changes, ready for review. |
lispc
reviewed
Dec 23, 2024
| pub fn handle_syscall(vm: &VMState, function_code: u32) -> Result<SyscallEffects> { | ||
| match function_code { | ||
| KECCAK_PERMUTE => Ok(keccak_permute::keccak_permute(vm)), | ||
| _ => Err(anyhow::anyhow!("Unknown syscall: {}", function_code)), |
There was a problem hiding this comment.
i think usually weak-typed anyhow err is not suitable for core lib functions, more suitable for app level errors.
We can add a TODO like "TODO: re-design err types when more precompile designs are done".
lispc
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trace generation
StepRecordto support multiple accesses to registers and memory (beyond standard instructions).fn handle_syscall(…)syscall_keccak_permute.Circuit part (standalone diff here)
There is a placeholder for upcoming precompile circuits. The real implementation must have the same effects as this one (same memory writes, etc).
LargeEcallDummyis an extension of the dummy circuit to support precompiles.keccak_step.