Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Past status of diabled jobs is referenced on restart #3183

Closed
yakanechi opened this issue Sep 4, 2024 · 2 comments
Closed

Past status of diabled jobs is referenced on restart #3183

yakanechi opened this issue Sep 4, 2024 · 2 comments

Comments

@yakanechi
Copy link
Contributor

What happened:
For example, the following pipeline is executed once
After that, "first2" is disabled and restarted from "first1".

In the current specification, "second" is triggered by reference to the past status of "first2", despite first2 being disabled.

This specification seems a bit strange to me.
The user should assume that "second" jobs and subsequent jobs that have "second" job as a trigger will also not be triggered because of the fact that it is disabled.

What you expected to happen:
Do not refer to the past status of disabled job.

How to reproduce it:
<- Start, Resart ->

jobs:
  first1:
    requires: [ ~commit ]
  first2:
    requires: [ ~commit ]
  second:
    requires: [ first1, first2 ]
@VonnyJap
Copy link
Member

VonnyJap commented Sep 12, 2024

@yakanechi @kumada626 - after discussing with others, we feel that this is the right implementation for the case of restart. The second job is restarted as the downstream effect after first1 restarted and even though the first2 is now disabled, it had been previously run in the parent event. So we conclude this should be the expected behavior.

@yakanechi
Copy link
Contributor Author

@VonnyJap
Thanks for the reply. I'm comfortable with that conclusion.
In that case, it looks good because it consistently inherits the parent status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants