Escaping of remote filenames containing spaces is broken for rsync

[omgold]

Describe the bug

If I want to copy a file from remote to local containing spaces, the space will be escaped with triple backslashes, but it should be only one.

To reproduce

If there is a named test file.txt when I try to complete

rsync localhost:test

I get the completion

rsync localhost:test\\\ file.txt

which doesn't work.

Expected behavior

It should be

rsync localhost:test\ file.txt

Versions (please complete the following information)

• [ x] Operating system name/distribution and version: Arch
• [ x] bash version, echo "$BASH_VERSION": 5.2.37(1)-release
• [ x] bash-completion version, (IFS=.; echo "${BASH_COMPLETION_VERSINFO[*]}"): 2.14.0

[yedayak]

Hi, what version of rsync are you using?
This should be fixed on the main branch, see this pr.
Can you try using the main branch and see if it works for you?

[omgold]

Okay tried it. It seems to be fix only partially, though.

It still misbehaves when there are 2 files present, test file.txt and test\ file.txt.

If I then try to complete

rsync localhost:test

at the first tab press I get

rsync localhost:test\

but on subsequent presses, I get no choices to pick from at all.

I'm using rsync 3.3.0

[yedayak]

Can you add set -x lines to completions/rsync?
like this:

106                 set -x #<------ Add this
107                 _comp_cmd_rsync__vercomp "$rsync_version" "3.2.4"
108                 if (($? == 2)); then
109                     _comp_compgen -x scp remote_files
110                 else
111                     _comp_compgen -x scp remote_files -l
112                 fi
113                 set +x <-----  # and this

And attach the output when completing with the issue?

[omgold]

@yedayak here you go.

rsync-complete-debug-output.txt

[scop]

I wonder if #1232 is the same issue as this one.