Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save parameters widget input values and load them from a dictionary #140

Open
Tracked by #61
YooSunYoung opened this issue Dec 4, 2024 · 4 comments · May be fixed by #148
Open
Tracked by #61

Save parameters widget input values and load them from a dictionary #140

YooSunYoung opened this issue Dec 4, 2024 · 4 comments · May be fixed by #148
Assignees
Labels
enhancement New feature or request

Comments

@YooSunYoung
Copy link
Member

We want to let users save parameters and auto-complete the parameter inputs from it.

@YooSunYoung YooSunYoung added the enhancement New feature or request label Dec 4, 2024
@YooSunYoung YooSunYoung self-assigned this Dec 4, 2024
@YooSunYoung YooSunYoung mentioned this issue Dec 4, 2024
16 tasks
@YooSunYoung YooSunYoung moved this from Triage to In progress in Development Board Dec 4, 2024
@jl-wynen
Copy link
Member

jl-wynen commented Dec 4, 2024

This is related to scipp/sciline#92. So ideally, the solution here can also be used with the JSON repr of Sciline. Even if it is not a complete solution to that issue.

@SimonHeybrock
Copy link
Member

I thought it should be distinct: Saving workflow parameters is different from storing the widget state. As a simple example, the workflow input parameters might be some bin-edges (an "arbitrary" variable), while the widget state gives start, stop, nbin, and scale (lin or log).

But maybe there is a better abstraction?

@YooSunYoung
Copy link
Member Author

Yeah, it's not really possible to fill widget inputs from a parameter value from the graph, i.e. scipp.Variable.
Maybe the title was misleading. I'll update it.

@YooSunYoung YooSunYoung changed the title Saving parameters and load them Save parameters widget input values and load them Dec 6, 2024
@YooSunYoung YooSunYoung changed the title Save parameters widget input values and load them Save parameters widget input values and load them from a dictionary Dec 6, 2024
@YooSunYoung
Copy link
Member Author

YooSunYoung commented Dec 10, 2024

There are some widgets that needs explicit handling.

TODO:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants