Missing Child Tag Persists

[ekemeyer]

Describe the bug
Even after adding the appropriate missing children to a GUID, the missing child record(s) tag persists. When attempting to push this record, it fails validation and so it can't be pushed to AAPB.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'record' or https://ams2.wgbh-mla.org/concern/asset_resources/cpb-aacip-15-93gxdjvq.xml to see xml
2. See children (one physical and one digital instantiation
3. Attempt to push to AAPB https://ams2.wgbh-mla.org/pushes/new?transfer=true&utf8=%E2%9C%93&search_field=all_fields&search_field=all_fields&q=%22cpb-aacip-15-93gxdjvq%22
4. See red flag warning of missing child record
5. Press send to AAPB, see no record of it in AAPB logs: https://americanarchive.org/logs/ingest-files.log

Expected behavior
When a child is added, the flag should disappear and allow for pushing to AAPB

[bkiahstroud]

Hi @ekemeyer 👋 The validation compares the Asset's "intended" number of children to its current number of children. This Asset has its Instantiations, yes, but the intended child count also includes each Instantiation's Essence Tracks:

intended_children_count = 0
intended_children_count += pbcore.instantiations.size
intended_children_count += pbcore.instantiations.map(&:essence_tracks).flatten.size

The Asset in question is intended to have 5 children total (instantiations + essence tracks), but currently only has 3:

flowchart TD
  A(Asset) --> B[PhysicalInstantiation]
  A --> C[DigitalInstantiation]
  C --> D[EssenceTrack]

Loading

So my best guess is one or both Instantiations are missing 1+ Essence Tracks

[ekemeyer]

@bkiahstroud thanks! That makes sense - I had made an attempt to add everything manually and wasn't thinking of the essence tracks.

I've come across a record that I ingested via the PBCore Zipped ingester, and so it should have all of its children and essence tracks. As far as I can tell, it does, but the missing child tag persists. Can you review this one and let me know what you see?
https://ams2.wgbh-mla.org/concern/asset_resources/cpb-aacip-15-086348gj58