-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling #20
Conversation
- Review appearance styles to verify which colors are being used. - Set up appropriate custom colors in appearance decorator, based on what is actually used in appearance_styles. - bring in default_colors_form to be able to render the color list.
@@ -1,7 +1,6 @@ | |||
@import url("https://fonts.googleapis.com/css2?family=Source+Sans+Pro:ital,wght@0,200;0,300;0,400;0,600;0,700;0,900;1,200;1,300;1,400;1,600;1,700;1,900&display=swap"); | |||
|
|||
body.public-facing { | |||
font-family: "Source Sans Pro" !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing font so the font selection in the appearance tab will work.
@@ -0,0 +1,26 @@ | |||
.viewer-wrapper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added due to custom css in the adventist_dl repo that was different than hyku.
Some custom CSS was incorrectly changed in a prior commit.
Sorry I missed clicking on the arrow. I see the drop down screenshot now. @laritakr Would a user have to switch to this theme? |
No themes at this point... they have a lot of custom CSS and that plus the complexity of how theming works with routes (and trying to fit that into the knapsack world) made doing it as a theme out of scope at this point. The goal for now is to reproduce what they already had, though I had hoped a theme would be a manageable way to do it. |
Story
Puts views into right position to get picked up.
Loads CSS.
Fixes assets precompile.
Sets up appearance colors and fonts with appropriate defaults.
Actions
Refs
Expected Behavior Before Changes
Layout is Hyrax basic.
Expected Behavior After Changes
Views mostly match current adventist.
Screenshots / Video
Style matches staging:
Fonts can be managed from appearance tab:
Notes
Prior custom CSS overrides a number of the appearance colors. This was not changed.