Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling #20

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Styling #20

merged 8 commits into from
Oct 3, 2023

Conversation

laritakr
Copy link
Contributor

@laritakr laritakr commented Oct 2, 2023

Story

Puts views into right position to get picked up.
Loads CSS.
Fixes assets precompile.
Sets up appearance colors and fonts with appropriate defaults.
Actions

Refs

Expected Behavior Before Changes

Layout is Hyrax basic.

Expected Behavior After Changes

Views mostly match current adventist.

Screenshots / Video

Style matches staging:
Screenshot 2023-10-02 at 10 24 25 PM

Fonts can be managed from appearance tab:
Screenshot 2023-10-02 at 11 19 32 PM

Notes

Prior custom CSS overrides a number of the appearance colors. This was not changed.

LaRita Robinson added 5 commits October 2, 2023 22:35
- Review appearance styles to verify which colors are being used.
- Set up appropriate custom colors in appearance decorator, based on
what is actually used in appearance_styles.
- bring in default_colors_form to be able to render the color list.
@laritakr laritakr marked this pull request as ready for review October 3, 2023 02:37
@@ -1,7 +1,6 @@
@import url("https://fonts.googleapis.com/css2?family=Source+Sans+Pro:ital,wght@0,200;0,300;0,400;0,600;0,700;0,900;1,200;1,300;1,400;1,600;1,700;1,900&display=swap");

body.public-facing {
font-family: "Source Sans Pro" !important;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing font so the font selection in the appearance tab will work.

@@ -0,0 +1,26 @@
.viewer-wrapper {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added due to custom css in the adventist_dl repo that was different than hyku.

@laritakr laritakr marked this pull request as draft October 3, 2023 02:54
LaRita Robinson added 3 commits October 2, 2023 22:59
@laritakr laritakr marked this pull request as ready for review October 3, 2023 03:26
@laritakr laritakr mentioned this pull request Oct 3, 2023
@ShanaLMoore
Copy link
Contributor

Sorry I missed clicking on the arrow. I see the drop down screenshot now. @laritakr Would a user have to switch to this theme?

@laritakr laritakr merged commit c352e63 into main Oct 3, 2023
2 of 7 checks passed
@laritakr laritakr deleted the styling branch October 3, 2023 14:57
@laritakr
Copy link
Contributor Author

laritakr commented Oct 3, 2023

Sorry I missed clicking on the arrow. I see the drop down screenshot now. @laritakr Would a user have to switch to this theme?

No themes at this point... they have a lot of custom CSS and that plus the complexity of how theming works with routes (and trying to fit that into the knapsack world) made doing it as a theme out of scope at this point. The goal for now is to reproduce what they already had, though I had hoped a theme would be a manageable way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants