Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If PDF.js is on, show PDF.js. Remove logic to fall back to UV if split works are present #903

Open
1 task
ShanaLMoore opened this issue Dec 5, 2024 · 1 comment

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Dec 5, 2024

Summary

There are issues with the special logic applied to fall back to the UV even with PDF.js is on, which occurs for specific conditions (ie: split works exist). Per Katharine, for now let's remove that logic and always show PDF.js when that feature flag is on.

https://assaydepot.slack.com/archives/C0313NJV9PE/p1733411068582639

Acceptance Criteria

  • Regardless of the conditionals, when PDF.js is enabled it should the display PDF.js viewer.

Screenshots or Video

Testing Instructions

To be filled out by dev

Notes

@ShanaLMoore ShanaLMoore converted this from a draft issue Dec 5, 2024
@KatharineV
Copy link
Collaborator

Just dropping in a note here. The existing logic is preferred, if the UV can be fixed so it will display split works as it did before the cutover. The existing logic is ideal when both viewers are functional. If it is possible to fix both the UV and PDF.js so they function as they did before Valkyrie and Version 6, then we would be thrilled.

Removing the logic and relying on just PDF.js is a last resort option that we choose simply to prioritize showing works throughout the repo.

Question: What will happen to non-PDF works if we remove the logic and rely on PDF.js? Will TIFF and JPEG works render in the viewer? Will embedded videos still display?

Thanks for answering that question and considering other paths before reverting the logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Development
Development

No branches or pull requests

2 participants