VS Code global search and replace inhibited

[KeithGrant]

Metals (v 1.19.0) seems to prevent a multiple file search and replace operation in VS Code from saving the changed files. Disabling the metals extension allows the global search and replace to work. Changes to files in the editor are saved those not in a tab are not saved when the metals extension is enabled however all files are saved correctly when metals is disabled.

[tgodzik]

Thanks for reporting! I haven't been able to reproduce it. All files are correctly saved, both those in the active tabs and the ones that are not open.

Is it possible it's caused by a specific settings conflict? I don't see any reason why Metals would block this from happening, but don't attach any hooks to on save. And especially, Metals doesn't know about any changes to files not currently opened.

[KeithGrant]

Thanks for the reply. I'll follow up. If I can find the core issue I'll let you know. Certainly looks like a corner case. From: Tomasz Godzik ***@***.***> Sent: Monday, August 22, 2022 8:32 AM To: scalameta/metals-vscode ***@***.***> Cc: KeithGrant ***@***.***>; Author ***@***.***> Subject: Re: [scalameta/metals-vscode] VS Code global search and replace inhibited (Issue #1118) Thanks for reporting! I haven't been able to reproduce it. All files are correctly saved, both those in the active tabs and the ones that are not open. Is it possible it's caused by a specific settings conflict? I don't see any reason why Metals would block this from happening, but don't attach any hooks to on save. And especially, Metals doesn't know about any changes to files not currently opened. - Reply to this email directly, view it on GitHub<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fscalameta%2Fmetals-vscode%2Fissues%2F1118%23issuecomment-1222446098&data=05%7C01%7C%7C572eb1edbc5f4990f1eb08da844b1936%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637967755326691327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BADHbfZJnYkh7eBwQy3158tUC5m6mIyibp5ebfMw56w%3D&reserved=0>, or unsubscribe<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABNDSL5XNP3IUW6LKOWV4QTV2OFOTANCNFSM57D6Q3WA&data=05%7C01%7C%7C572eb1edbc5f4990f1eb08da844b1936%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637967755326691327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=E3%2F%2BWIwuR87g%2F8vKGbAd4geOVI8JEPXw0rSt8lADpoU%3D&reserved=0>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[mlhales]

I am seeing this problem too, currently. Using v1.21.0 and up to date vscode.

I was wondering if it was maybe scalafmt running after the save, but having the old source cached or something like that?

[KeithGrant]

I think so. When I removed the .scalafmt.conf file global search and replace worked. From: Mike Hales ***@***.***> Sent: Wednesday, January 18, 2023 10:23 AM To: scalameta/metals-vscode ***@***.***> Cc: KeithGrant ***@***.***>; Author ***@***.***> Subject: Re: [scalameta/metals-vscode] VS Code global search and replace inhibited (Issue #1118) I am seeing this problem too, currently. Using v1.21.0 and up to date vscode. I was wondering if it was maybe scalafmt running after the save, but having the old source cached or something like that? — Reply to this email directly, view it on GitHub<#1118 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABNDSL6BBACQABVLYK73OWTWTARHXANCNFSM57D6Q3WA>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>