Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite for eta-expension #131

Open
MasseGuillaume opened this issue Aug 2, 2018 · 2 comments
Open

Rewrite for eta-expension #131

MasseGuillaume opened this issue Aug 2, 2018 · 2 comments
Labels
rewrite Related to rewrite rules (not compat library code)

Comments

@MasseGuillaume
Copy link
Contributor

MasseGuillaume commented Aug 2, 2018 •
edited
Loading

One of the probably many paterns to rewrite (see scala/scala#6475 for more details):

class C(in: () => Int)
def f(): Int = 1

new C(f) // does not compile anymore in 2.13.0-M4
-new C(f)
+new C(() => f)
MasseGuillaume added a commit to MasseGuillaume/akka that referenced this issue Aug 2, 2018
@MasseGuillaume
Manually eta-expand see scala/scala-collection-compat#131
254431b
@SethTisue
Copy link
Member

I tend to still write f _, but I guess in the long run that syntax is on its way out

@SethTisue
Copy link
Member

(ironically, that syntax is on its way out because new C(f) is going to be made to work again...)

raboof pushed a commit to akka/akka that referenced this issue Nov 23, 2018
@MasseGuillaume @raboof
Manually eta-expand see scala/scala-collection-compat#131
4f7c9e6
raboof pushed a commit to akka/akka that referenced this issue Nov 23, 2018
@MasseGuillaume @raboof
Manually eta-expand see scala/scala-collection-compat#131
edeacce
raboof pushed a commit to akka/akka that referenced this issue Dec 5, 2018
@MasseGuillaume @raboof
Manually eta-expand see scala/scala-collection-compat#131
6a998cf
raboof pushed a commit to akka/akka that referenced this issue Dec 5, 2018
@MasseGuillaume @raboof
Manually eta-expand see scala/scala-collection-compat#131
285361d
raboof pushed a commit to akka/akka that referenced this issue Dec 7, 2018
@MasseGuillaume @raboof
Manually eta-expand see scala/scala-collection-compat#131
ec40d4a
raboof pushed a commit to akka/akka that referenced this issue Dec 7, 2018
@MasseGuillaume @raboof
Manually eta-expand see scala/scala-collection-compat#131
7414b75
raboof pushed a commit to akka/akka that referenced this issue Dec 15, 2018
@MasseGuillaume @raboof
Manually eta-expand see scala/scala-collection-compat#131
226cdb8
raboof pushed a commit to akka/akka that referenced this issue Dec 18, 2018
@MasseGuillaume @raboof
Manually eta-expand see scala/scala-collection-compat#131
bf827d6
raboof pushed a commit to akka/akka that referenced this issue Jan 8, 2019
@MasseGuillaume @raboof
Manually eta-expand see scala/scala-collection-compat#131
3265b7d
raboof pushed a commit to akka/akka that referenced this issue Jan 9, 2019
@MasseGuillaume @raboof
Manually eta-expand see scala/scala-collection-compat#131
6754a4e
raboof pushed a commit to akka/akka that referenced this issue Jan 11, 2019
@MasseGuillaume @raboof
Various fixes for scala-2.13.0-M5
10575ce 
Manually eta-expand see scala/scala-collection-compat#131

MapLike => Map

Rewrite filterKey with ApplyInfix syntax

Manually fix scala/bug#11033

Manually fix compat layer

since it's 2.13, it's not picked up by scalafix
@szeiger szeiger added the rewrite Related to rewrite rules (not compat library code) label Apr 5, 2019
martijnhoekstra pushed a commit to martijnhoekstra/scala-collection-compat that referenced this issue Nov 9, 2022
@NthPortal
Merge pull request scala#131 from scala-steward/update/sbt-1.4.9
6035984 
Update sbt to 1.4.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rewrite Related to rewrite rules (not compat library code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@szeiger @SethTisue @MasseGuillaume