Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Section default options for land-width parsing and cube geometries #35

Open
amoodie opened this issue Oct 26, 2020 · 0 comments
Assignees
Labels
cube enhancement New feature or request section

Comments

@amoodie
Copy link
Contributor

amoodie commented Oct 26, 2020

I know this is a 'temporary' method until we add the land width to the netCDF file, but could this be called during cube initialization and held in the cube as self._trim_idx or something similar? Might make the swap down the line easier to implement as the function would be called once during initialization instead of spread across multiple files/methods?

(#26 (comment))

Probably a good idea, and related to a bug that sprung up on the RadialSection too.

After updating the netcdf file, create some attributes of the cube based on whether those attributes exist in the netcdf file will make the most sense.

For example, if L0 is in the netcdf, then make self.L0 in the Cube and then when creating a Section, you can check whether Cube.L0 exists, and use it if it does.

@amoodie amoodie added enhancement New feature or request cube section labels Oct 26, 2020
@amoodie amoodie self-assigned this Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cube enhancement New feature or request section
Projects
None yet
Development

No branches or pull requests

1 participant