-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High cpu usage when media is playing #135
Comments
@sakithb I have the feeling it is the same which I told you in a discussion and its related to slider. (I made a local change to not have the slider for now) |
there's nothing at all output to the journal when I open the popup, alas. |
That could be true. |
Is it recreatable while playing a track with no album art? |
it is. |
We can try If you have the same problem I have on debian testing. |
yep, confirmed: no slider, no problem. |
So this means our distros need to update I guess. I am on debian testing - you are NIXOS unstable. |
you mean our respective gnome-shell versions are too old, or something else? |
Not really sure If it is gnome-shell, gjs, mutter, clutter etc. |
interesting! another reason could be some quirk of a particular MPRIS2 server implementation. when I was experiencing the problem the player was MPD behind mpdris2. too lazy to revert the patch and check other players now. |
@sakithb an acceptable solution of sorts could be just providing a config knob to disable the slider. |
U are using an unstable distro. You should accept that problems might be there. Me as well. It will work as soon as some update comes. I workarounded the problem for me (and you). Fine for now I guess. |
Using Ubuntu 23.10, with Media Controls v34. Getting freezes on play start (in particular youtube) and memory leak in Gnome Shell while using Spotify for long periods (typical work day). Tracked it down to this extension. Here is some bits of relevant logs from journal around the freeze time:
|
This seems to be something different and not related to the slider. But to be sure - can you try with the attached PanelButton.js from this post: #135 (comment) |
@sakithb I think I know how to reproduce the slider issue: |
After a song changes - it can happen again. Somehow the panelbutton slider runs auf of sync with the song position and then it starts spamming. |
Okay, I will take a look at that during the next week |
I have the feeling the slider should only run when the panelbutton is shown. |
The new PanelButton has solved my issues. My test case was to open any youtube video using Metastream (https://getmetastream.com/ for reference). With old PanelButton it freezes the whole gnome-shell for a while (as its probably does multiple seek requests under the hood to sync the video on everyone sessions). New PanelButton has no such issues. |
@ChrisLauinger77 Do you still get these issues with the release on EGO? |
Yes it is still the same log spamming and i again disabled the slider. |
PSA: meanwhile, https://github.com/Moon-0xff/gnome-mpris-label works great. admittedly it has an easier job because it does not try to be a full-blown player UI |
The issue occurs because of the slider, I will try to find ways to optimize it when I get some time. |
The PanelButton.js in this thread is seems outdated now and the extension does not works when file is replaced on latest release v2.0.1 @ChrisLauinger77 can you please post an updated version? I have been able to get OOM after a few hours of youtube binging on 2x-3x speed with regular PanelButton from the latest update. |
@Spurlos Yes sure - I attach it to the thread you mentioned in the evening |
PanelButton_2.0.1.zip |
I yesterday updated my monitor config. |
What are we considering high cpu usage on an ubuntu-like os running gnome 46? I found this thread looking to see if mpd was supported and I'm seeing 10x higher cpu usage with media-controls running (ca. 30% vs. ca. 3% for gnome-shell reported by htop). |
in the mean time I think it may be a pretty urgent item to at least provide an official way to disable the slider entirely. |
Maybe the slider is an issue, but I've noticed something more general where when the media title is longer than the label width, the title will scroll, which consumes more CPU, compared to the media with shorter titles or wider label settings. It is clear. |
To Reproduce
I lack the skills to diagnose this any more precisely, sorry.
Thankfully disabling/enabling the extension clears the condition -- until you happen to open the popup again, that is.
Desktop (please complete the following information):
Smartphone (please complete the following information):
You may want to edit this bug report template? 😄
The text was updated successfully, but these errors were encountered: