Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Programmatic configuration of safe master copy #102

Closed
peterpolman opened this issue Jul 19, 2023 · 6 comments · May be fixed by safe-global/safe-transaction-service#1785
Closed

Programmatic configuration of safe master copy #102

peterpolman opened this issue Jul 19, 2023 · 6 comments · May be fixed by safe-global/safe-transaction-service#1785

Comments

@peterpolman
Copy link
Contributor

peterpolman commented Jul 19, 2023 •
edited
Loading

Hi team!👋 I'm using safe-infrastructure in a github workflow together with a hardhat node and I have trouble with the required manual configuration steps. Locally I'm using the txs admin UI to set the safe master copy address. Is there a (convenient) way to configure the safe master copy address programmatically?
@peterpolman peterpolman changed the title Programmatic configuration of chaininfo and safe master copy Programmatic configuration of safe master copy Jul 19, 2023
@peterpolman
Copy link
Contributor Author

Perhaps running some SQL commands to set the database values would suffice?

@Uxio0
Copy link
Member

Uxio0 commented Aug 1, 2023

Sure, you can use some SQL or a Django management script to achieve that

@peterpolman
Copy link
Contributor Author

peterpolman commented Aug 1, 2023 •
edited
Loading

Ended up sharing a migration through docker volumes which sets default values. As this is a bit hacky I will change that into a manage.py custom command which should allow to insert a safe master copy through the CLI. Want me to add a PR for that?

All in all it worked out fine, the infra is now running in our GH actions and the API tests run against it nicely ❤️ 🙏

@Uxio0
Copy link
Member

Uxio0 commented Aug 1, 2023

Ended up sharing a migration through docker volumes which sets default values. As this is a bit hacky I will change that into a manage.py custom command which should allow to insert a safe master copy through the CLI. Want me to add a PR for that?

Sure thing

All in all it worked out fine, the infra is now running in our GH actions and the API tests run against it nicely ❤️ 🙏

Good to hear that!

@Uxio0
Copy link
Member

Uxio0 commented Nov 8, 2023

Closing this due inactivity

@Uxio0 Uxio0 closed this as completed Nov 8, 2023
@peterpolman peterpolman mentioned this issue Nov 30, 2023
Open
3 tasks
@peterpolman
Copy link
Contributor Author

peterpolman commented Nov 30, 2023 •
edited
Loading

@Uxio0 Better late than never I guess!😉 Submitted a PR but wasn't able to run tests locally (see comment on PR). The new command works fine in our CI though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds management command for inserting safe master copy peterpolman/safe-transaction-service
2 participants
@peterpolman @Uxio0