Add Support for Pre-approved IsValidSignature #867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
force-pushed
the
feat/support-pre-approved-1271-signature
branch
3 times, most recently
from
6984754 to
8a9b056
Compare
This commit demonstrates how `isValidSignature` can be modified to support pre-approved signatures where the `caller` has an implicit signature (similar to how `execTransaction` works).
nlordell
force-pushed
the
feat/support-pre-approved-1271-signature
branch
from
8a9b056 to
12f1095
Compare
|
Closing in favour of #866 - the rationale is that this would change existing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies how
isValidSignaturesupport pre-approved signatures where thecallerhas an implicit signature (similar to howexecTransactionworks).Note that we remove the new 1.5.0-only
checkSignaturesinterface in favour of one withexecutorexplicitly provided to avoid issues for contracts that make use of this function.