Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong chain-id for zksync testnet #1044

Open
kkirkov opened this issue Nov 8, 2024 · 1 comment · Fixed by safe-global/safe-deployments#899 or #1067
Open

Wrong chain-id for zksync testnet #1044

kkirkov opened this issue Nov 8, 2024 · 1 comment · Fixed by safe-global/safe-deployments#899 or #1067
Assignees
@dasanra

Comments

@kkirkov
Copy link

kkirkov commented Nov 8, 2024 •
edited
Loading

Description

  • packages/protocol-kit/src/contracts/utils.ts:51: const ZKSYNC_TESTNET = 280n
    • should be const ZKSYNC_TESTNET = 300n
  • packages/protocol-kit/src/utils/eip-3770/config.ts:67: { chainId: 300n, shortName: 'ogn' },
    • should be { chainId: 300n, shortName: 'zksync-sepolia' },

Additional context

Can't use sdk to deploy a Safe multisig wallet on zkSync Sepolia Testnet via create2
@dasanra dasanra self-assigned this Nov 11, 2024
@dasanra
Copy link
Collaborator

dasanra commented Nov 11, 2024

Depending on these two issues

safe-global/safe-deployments#686
safe-global/safe-deployments#838

@akshay-ap akshay-ap mentioned this issue Dec 4, 2024
Merged
akshay-ap added a commit to safe-global/safe-deployments that referenced this issue Dec 4, 2024
@akshay-ap
Update address for chain id 300 (#899)
52fe9fa 
Fixes: #686
Fixes: safe-global/safe-core-sdk#1044

Changes in PR:

- Fixes addresses for chain id 300 which is zksync testnet.
@yagopv yagopv linked a pull request Dec 4, 2024 that will close this issue
chore: bump safe-deployments #1067
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasanra dasanra

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dasanra @kkirkov