Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate indexing options for recovery proposals #1039

Open
iamacook opened this issue Jan 17, 2024 · 0 comments
Open

Investigate indexing options for recovery proposals #1039

iamacook opened this issue Jan 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@iamacook
Copy link
Member

iamacook commented Jan 17, 2024

The web is currently using RPC calls to retrieve recovery proposals. This is both costly and inefficient, with some chains not supporting the implementation.

We should investigate the options available for indexing (e.g. The Graph) to instead include said proposals in the transaction queue.

As each module is deployed per Safe so we would need need to index ModuleProxyCreation events of Zodiac's ModuleProxyFactory contract and then the TransactionAdded events of each Delay modifier.

Grouping recovery attempts and their cancellations

This logic is currently also on the frontend. It finds a cancellation transaction (which is a regular Safe tx, a contract call) in the queue, and visually groups it with the corresponding recovery. This results in cancellations being displayed in two places – regular queue and pending recovery queue.

This logic should be moved to CGW and handled holisitcally.

@PooyaRaki PooyaRaki added the enhancement New feature or request label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants