webidl-bindings table does not contain valid function indices

[yurydelendik]

🐛 Bug description

The wasm-pack executes step wasm_opt after wasm_bindgen. The wasm_bindgen generates 'webidl-bindings' table with specific function ids in it. When wasm_opt is run, the function ids changed, e.g. some import or local functions are removed, thus breaking the webidl-bindings references.

🤔 Expected Behavior

The 'webidl-bindings' table contains right indices.

👟 Steps to reproduce

(Too deep a bug chain, depends on fixes at rust-lang/rust#64187 and #654)

🌍 Your environment

Include the relevant details of your environment.
wasm-pack version: 0.8.1
rustc version:

/cc @alexcrichton

[alexcrichton]

Ah yes right! For now you'll have to disable wasm-opt when using wasm interface types. @yurydelendik are you using a master-built version of wasm-pack or a prebuilt version? (I don't think the prebuilt versions run wasm-opt yet)

[yurydelendik]

are you using a master-built version of wasm-pack or a prebuilt version?

I'm using the master since I need workarounds for the wasm32-wasi target.

[alexcrichton]

Ah ok, if you do:

# ... at the end of Cargo.toml
[package.metadata.wasm-pack.profile.release]
wasm-opt = false

does that fix the issue?

[yurydelendik]

does that fix the issue?

I commented the step in the code, and it fixed the issue and allowed me to create an output wasm where wasmtime properly gets the export metadata. (I observe next issue during running of wasmtime, but I think it is unrealed)

[alexcrichton]

Ah ok, great!

I think in the long term we would want to automatically disable wasm-opt if interface types are enabled (at least until wasm-opt has interface types support), but until that happens are you ok closing this in the meantime?

[yurydelendik]

are you ok closing this in the meantime?

yes. closing