-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trait impl disappeared without bumping major version #94
Comments
We could make |
@newpavlov I agree, we should enable the We should prioritize not breaking EDIT2: |
I think the solution here is to yank 0.1.10 and prepare 0.2.0? |
@dhardy I agree. My idea is as follows:
|
Sorry to be the bearer of versioning news,
0.1.10
contains a backwards-incompatible change with respect to0.1.8
and so on - the feature flags arounderror_impls
changed, and had been accidentally(?) includingerror_impls
for specific OSes regardless ofstd
being selected or not.The change around feature flags makes sense, but without bumping major versions, version
0.1.10
can cause breakages: see the end of the log here. The missing impl is becauseminisign
depends ongetrandom = "0.1.3"
, where0.1.10
should be a backwards compatible update, but is not due to the missing trait. We can work around that by specifyingstd
, but I wanted to make sure y'all knew about this.The text was updated successfully, but these errors were encountered: