Rename rust-analyzer.statusBar.documentSelector to showStatusBar, add "always" and "never" options.
#18722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Dec 20, 2024
|
CI is red |
auto-merge was automatically disabled
December 20, 2024 21:41
Head branch was pushed to by a user without write access
markmurphydev
force-pushed
the
status_bar_settings
branch
from
a19a9fc to
ed0df30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18665.
rust-analyzer.statusBar.showStatusBarcan be"always","never"or{ "documentSelector": <DocumentSelector>[] }.I added
DocumentSelector.notebookTypeand.schemeas possible properties. The array is passed directly tovscode.languages.match(documentSelector, editor.document), so the properties should Just Work.Manually testing,
"always","never", and{ "documentSelector": ... }seemed to work correctly.I think the renamed setting is clearer, but it will break previous
statusBar.documentSelectorconfigs.