Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steering Issue 21 #18479

Open
1 of 6 tasks
Veykril opened this issue Nov 5, 2024 · 2 comments
Open
1 of 6 tasks

Steering Issue 21 #18479

Veykril opened this issue Nov 5, 2024 · 2 comments
Labels
C-tracking-issue Category: tracking issue

Comments

@Veykril
Copy link
Member

Veykril commented Nov 5, 2024

Zulip meeting
Previous issue: #16013

  • Land the new salsa via the transition macro (@davidbarsky)
    • Slowly migrate away from the transition macro to native salsa features
    • Move interning of type IR to chalk (merge once salsa has GC)
  • Look more into the new trait solver
  • Move more assists to syntax editor Migrate assists to SyntaxEditor #18285
  • Check the 2024 edition, see what we are missing 2024 Edition  #16146 (issue is not complete)
@Veykril Veykril added the C-tracking-issue Category: tracking issue label Nov 5, 2024
@Ten0
Copy link

Ten0 commented Nov 13, 2024

Look more into the new trait solver

What does this mean? Is there potential that chalk would be replaced in rust-analyzer?
(I'm currently experiencing super slow RA every time I touch my code (30s lag at 100% CPU after touching anything before RA starts answering queries again) and perf tells me all the time is spent in chalk_recursive::solve::SolveIterationHelpers::solve_from_clauses, I'm wondering whether the next step may be to just change solver, or if it's worth investigating.)

@ChayimFriedman2
Copy link
Contributor

@Ten0 It's not just potential, it's pretty much guaranteed. Chalk is no longer developed and the new trait solver is supposed to replace both rustc's old trait solver and Chalk in r-a.

The new trait solver is supposed to be more efficient than Chalk (especially given it will also be used in rustc, which means it will see heavy perf work, something Chalk didn't have), but that doesn't necessarily mean it will solve your problem. We will have to wait and see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: tracking issue
Projects
None yet
Development

No branches or pull requests

3 participants