Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run try with a specific parent commit #177

Open
Kobzol opened this issue Jul 10, 2022 · 0 comments
Open

Run try with a specific parent commit #177

Kobzol opened this issue Jul 10, 2022 · 0 comments

Comments

@Kobzol
Copy link
Contributor

Kobzol commented Jul 10, 2022

I often want to test multiple related changes in PRs that can affect performance and compare the performance effect of these changes. The usual workflow is like this:

  1. Commit A
  2. Run try build + perf run. The try build will use parent commit P1.
  3. Commit B
  4. Run try build + perf run. The try build will use parent commit P2.

The problem with this approach is that between the commits A and B are built using try, the parent commit from master might have changed already and therefore P1 != P2. Master changes multiple times per day, so it can happen even if you schedule the second try build right after the previous one has finished. This makes it impossible to precisely compare the performance of A and B.

It would be nice to have the option to say something like @bors try parent=<commit sha> so that when I run the second try build, I can manually specify parent P1 to make sure that I am comparing against the same baseline. Or even something like @bors try parent=last to make the bot use the latest parent commit, so that I don't have to look it up.

I checked the code briefly and I think that it could be done by optionally replacing this with a commit sha specified in the try command (?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant