Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose zlib fine-tuning options in high-level API #233

Open
RReverser opened this issue Apr 14, 2020 · 0 comments
Open

Expose zlib fine-tuning options in high-level API #233

RReverser opened this issue Apr 14, 2020 · 0 comments

Comments

@RReverser
Copy link
Contributor

Just moving from a comment (#230 (comment)) to a proper tracking issue:

@RReverser > @alexcrichton Somewhat related. I've noticed that higher-level APIs currently don't expose these advanced zlib configurations, which seems a shame because they're much easier to use than Compress / Decompress directly, and sometimes you really need that fine-tuning.
Would you be open to adding either new methods to ZlibEncoder / ZlibDecoder to propagate corresponding params, or adding implementations of From<Compress> / From<Decompress> so that one could create a high-level wrapper for a preconfigured instance?

@alexcrichton > In terms of adding higher-level APIs, yes, that seems fine to me too. I would prefer it if were a separate PR though and for this to not balloon too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant