-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce perma-unstable wasm-c-abi
flag
#703
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:
Concerns can be lifted with:
See documentation at https://forge.rust-lang.org cc @rust-lang/compiler @rust-lang/compiler-contributors |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Please keep the conversation in the zulip thread linked in #703 (comment) |
@rustbot second This will need a tracking issue. This second is also predicated on the overall plan of moving towards a spec-compliant ABI continues as expected. If that changes, the flag should be removed (or at least reevaluated!) |
@rustbot label -final-comment-period +major-change-accepted |
Proposal
Currently Rust uses a non-spec-compliant ABI for
extern "C" fn
when compiling towasm32-unknown-unknown
. Unfortunately, as a large part of the Rust ecosystem relies onwasm-bindgen
, which didn't support the spec-compliant ABI, switching to the spec-compliant ABI was problematic as it would break a lot of code out there.With
wasm-bindgen
v0.2.88, it now supports the spec-compliant ABI, so hopefully some day in the future Rust can switch to this ABI. In the meantime it would be important for users to test this new ABI, which is the purpose of this MCP: to introduce a new flag which switches to this new ABI when targettingwasm32-unknown-unknown
.This flag would be perma-unstable, as there is no point to stabilize it and then just deprecate it when the new ABI becomes the default.
Related issue: rust-lang/rust#71871
Implementation PR: rust-lang/rust#117919
The text was updated successfully, but these errors were encountered: