Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show whether the client is running in safe mode in Discord rich presence #16659

Closed
Nightfirecat opened this issue Jun 6, 2023 · 3 comments · Fixed by #16667
Closed

Show whether the client is running in safe mode in Discord rich presence #16659

Nightfirecat opened this issue Jun 6, 2023 · 3 comments · Fixed by #16667

Comments

@Nightfirecat
Copy link
Member

Nightfirecat commented Jun 6, 2023

We should prepend (safe mode) to the Discord rich presence tooltip, the same way it's done in the title bar.

@shi-vy
Copy link
Contributor

shi-vy commented Jun 9, 2023

Hello, I was interested in doing this for my first contribution but I think it's a bit more involved than it initially seems.

So, for Rich Presence I believe that the init that runs here loads in the "RuneLite" title in rich presence.

Once rich presence is initialized, it can be updated, with these values. Note that none of these values update the title itself. So I think rich presence can't actually be used to edit the title, and that the game title is linked to the Discord app id. But I could be wrong, I am no expert.

P.S. DiscordRPC is deprecated in favor of the Discord GameSDK, and Rich Presence is now meant to be implemented via the Activity Manager. I'm not sure if the desired output can be achieved via the new SDK either :(

@geheur
Copy link
Contributor

geheur commented Jun 9, 2023

pretty sure the text would be added here https://github.com/runelite/runelite/blob/49ce8dbf1e01eada005533856d450f4db14d8e84/runelite-client/src/main/java/net/runelite/client/plugins/discord/DiscordState.java#LL170C20-L170C20

doesn't sound that difficult.

@Nightfirecat
Copy link
Member Author

Changing the hover text is what we want, not changing the name of the application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants