Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: test_captures #82

Open
olleolleolle opened this issue Jan 15, 2024 · 5 comments
Open

Test failure: test_captures #82

olleolleolle opened this issue Jan 15, 2024 · 5 comments

Comments

@olleolleolle
Copy link
Contributor

The changes in
1fbfdd3
fail on 3.2 and 3.3, it seems. ruby-head seems to pass this test.

Details

Failure looks like this:


Run ruby run-test.rb
Loaded strscan from /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/3.2.0/x86_64-linux/strscan.so
Gem from 
Loaded suite run-test
Started
...F
===============================================================================
Failure: test_captures(TestStringScanner)
/home/runner/work/strscan/strscan/test/strscan/test_stringscanner.rb:751:in `test_captures'
     748:     s = create_string_scanner("Timestamp: Fri Dec 12 1975 14:39")
     749:     s.scan("Timestamp: ")
     750:     s.scan(/(\w+) (\w+) (\d+) (1980)?/)
  => 751:     assert_equal(["Fri", "Dec", "12", nil], s.captures)
     752:     s.scan(/(\w+) (\w+) (\d+) /)
     753:     assert_nil(s.captures)
     754:   end
<["Fri", "Dec", "12", nil]> expected but was
<["Fri", "Dec", "12", ""]>

diff:
? ["Fri", "Dec", "12", nil]
?                      ""  
?                      ???  
===============================================================================
/home/runner/work/strscan/strscan/test/strscan/test_stringscanner.rb:788: [BUG] Segmentation fault at 0x0000000000000014
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]
@olleolleolle
Copy link
Contributor Author

olleolleolle commented Jan 15, 2024

cc @naitoh Perhaps you know more?

I saw this when I tried to update the CI to use the shared "ruby versions from a remote JSON" GitHub Actions action in #74.

@kou
Copy link
Member

kou commented Jan 15, 2024

It uses strscan in Ruby not installed by gem install strscan.gem explicitly.
I think that this is a bug of RubyGems or something but I haven't looked into this yet...

@olleolleolle
Copy link
Contributor Author

@kou I see. In light of that, should we merge #74 now?

@kou
Copy link
Member

kou commented Jan 15, 2024

If the failed jobs are also failed on master with the same reason, I'm OK with it.

@olleolleolle
Copy link
Contributor Author

@kou Yes, I checked, and yep, it's with the same reason. I will merge it, thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants