Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for custom bundler config #105

Closed
bergos opened this issue Dec 15, 2022 · 1 comment · Fixed by #106
Closed

Remove requirement for custom bundler config #105

bergos opened this issue Dec 15, 2022 · 1 comment · Fixed by #106

Comments

@bergos
Copy link
Contributor

bergos commented Dec 15, 2022

I'm trying to remove the requirement for custom bundler configs for all @rdfjs packages. I stumbled over this line in the jsonparse package. It works after manually adding the following line on top of jsonparse.js:

var { Buffer } = require('buffer')

I'm aware there is a bounty for #76, and I also saw #100. That's why I'm asking how to solve this problem. jsonparse didn't receive any updates for six years. A quick and pragmatic solution would be to fork jsonparse, fix only the Buffer import, and use the forked package. That would also be my proposal if there aren't any other plans which would also solve this problem.

@rubensworks How can I help if you agree with the proposed solution? I can create and publish the fork, but if you have some more changes in mind, keeping the fork under your user would be better.

@rubensworks
Copy link
Owner

We have a WIP fork of jsonparse.js in https://github.com/comunica/json-event-parser.js, but it does much more than including the buffer dependency.
It is unknown at this stage when the migration to json-event-parser.js will be finished, so perhaps we can have an interim solution for now indeed.

So yes, I agree with the proposed solution! (It will likely be temporary though)

rubensworks pushed a commit that referenced this issue Jan 3, 2023
This removes the need to use custom Web bundler configs
by not depending on Node.js built-ins.

Closes #105
Related to #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants