Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDRP support #1

Closed
Blindsp0t-creative opened this issue Feb 26, 2019 · 21 comments
Closed

HDRP support #1

Blindsp0t-creative opened this issue Feb 26, 2019 · 21 comments
Labels
enhancement New feature or request

Comments

@Blindsp0t-creative
Copy link

Hi !
And thanks a lot for providing this addon. I'm wondering if you plan to update it to the new rendering pipeline of Unity ?
I'd like to play with the visual effect graph in a dome :)

Thanks again

@rsodre
Copy link
Owner

rsodre commented Feb 26, 2019

Hi!
This plugin is basically a camera setup, so should work with any scene.
Are you having difficulties with any Unity feature?

@Blindsp0t-creative
Copy link
Author

Yes. I can't get no deformation using the prefab with a "High Definition Rendering Pipeline" project.

here is a screenshot :

screenShot1

I confirm i also put the "fulldome preview" script on the mainCamera:

screenShot2

@rsodre
Copy link
Owner

rsodre commented Mar 17, 2019

What's your Unity version?

@Blindsp0t-creative
Copy link
Author

2018.3.8f1

@rsodre
Copy link
Owner

rsodre commented Mar 21, 2019

Just tried with the 2018.3.3 HDRP test scene and indeed seems not to work.
I'll try to find out why.

@rsodre rsodre added the enhancement New feature or request label Apr 8, 2019
@rsodre
Copy link
Owner

rsodre commented Apr 8, 2019

Unfortunately that the HD Pipeline does not fire the Camera's callbacks the plugin needs to render the Fulldome image. Sounds like they will include more callbacks in the future, I'll keep an eye on it and update this issue is anything changes.

But I'm working in an alternative, hold a while...

@rsodre
Copy link
Owner

rsodre commented Apr 9, 2019

No luck, looks like this has to be solved so I can do this...

@Blindsp0t-creative
Copy link
Author

Hm... ok, i get it. Hope this will be fixed soon!

@rsodre rsodre changed the title New rendering pipeline and visual effect graph HDRP and VFX Graph support Apr 21, 2019
@dpentecost
Copy link

Thanks - This is working great in 2018.3+ other than HDRP - using NDI or Spout to get some of that into the fulldome scene. Standing by to see if Unity helps us out on this! Any news?

@ahfontaine
Copy link

Hey! It seems like Unity fixed the blocking issue.

@rsodre
Copy link
Owner

rsodre commented Jul 30, 2019

Yes, there's been some exciting new developments!
I'm downloading 2019.2 to try them out

@dpentecost
Copy link

dpentecost commented Jul 30, 2019 via email

@rsodre
Copy link
Owner

rsodre commented Jul 31, 2019

I have made a working example with HDRP (ExampleHDRP.unity). It's at the HDRP branch.

It's based on the Unity Recorder, cleaner than the original camera callbacks, and runs on the standard renderer too. I think I'll replace the main scripts later, let's see if it works well.

On this new workflow, the main camera can be disabled, since the frame will be rendered manually and copied to the backbuffer. The Game view says "No cameras rendering", but I don't see any problem. I don't know how it will work on a compiled game, if anyone could try...

@rsodre rsodre changed the title HDRP and VFX Graph support HDRP support Jul 31, 2019
@rsodre
Copy link
Owner

rsodre commented Jul 31, 2019

VFX Graph support will be dealt in Issue #3

@Blindsp0t-creative
Copy link
Author

Such great news here !! :))

@dpentecost
Copy link

Tried in both MacOS and Windows. Builds fine in the 2019.2 version, quits without building in the HDRP example. Have you tried using the HDRP version with Spout or NDI? Any tips for doing that?

@dpentecost
Copy link

Just got it working on Keijiro's DKVfx example, using a DepthKit recording we made - success! Thank you! This opens up a lot of new VFX stuff for the dome.

BUT the inability to build an app (which gives us true fullscreen top to bottom of the frame) prevents us from using it well in our dome, since unless we mirror a fullscreen app, Unity gives us a fullscreen window in play mode. Window bars show up in the dome. Any ideas?

@rsodre rsodre mentioned this issue Aug 2, 2019
rsodre added a commit that referenced this issue Aug 2, 2019
@rsodre
Copy link
Owner

rsodre commented Aug 2, 2019

I merged into master, there's a lot of changes in the plugin structure, and some new stuff I'm working on if anybody wanna try. After pull, you can delete the old FulldomeCamera folder, since now everything is in FulldomeForUnity. I changed the main folder name exactly to force these big changes, and to welcome the new stuff in. But you'll find the FulldomeCamera inside it.

Good news: The new FulldomeCamera.cs script has a better performance on Standard renderer!

Bad news: It is quite bad on HDRP. Let's find out why and fix it :)

@rsodre
Copy link
Owner

rsodre commented Aug 2, 2019

@dpentecost , I still did not try the Metal Syphon or NDI. And I'm allergic to Windows, hope will never need to get close to Spout.

I don't know how they will react to the changes, that should be the next step.

@rsodre
Copy link
Owner

rsodre commented Aug 15, 2020

Current master branch is compatible with HDRP.

@rsodre rsodre closed this as completed Aug 15, 2020
@dpentecost
Copy link

dpentecost commented Aug 15, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants