Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings coming from common_interfaces. #1275

Closed
wants to merge 1 commit into from
Closed

Fix warnings coming from common_interfaces. #1275

wants to merge 1 commit into from

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Sep 5, 2024 •
edited
Loading

Fixes #1274

@clalancette clalancette requested a review from ahcorde as a code owner September 5, 2024 17:40
@clalancette
Copy link
Contributor Author

This should fix the regression introduced by ros2/common_interfaces#247 . @Crola1702 FYI.

@clalancette
Copy link
Contributor Author

Pulls: #1275
Gist: https://gist.githubusercontent.com/clalancette/fd69808d2c02048defc582d8f3bf8c70/raw/5bacd674f3e97c3ff0498844b26dc4c4b96d6dcf/ros2.repos
BUILD args: --packages-above-and-dependencies sensor_msgs
TEST args: --packages-above sensor_msgs
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14519

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor Author

Actually, never mind. That PR to common_interfaces caused unrelated warnings on Windows. I'm going to close this out and actually revert that commit.

@clalancette clalancette closed this Sep 5, 2024
@clalancette clalancette deleted the clalancette/fix-warnings branch September 5, 2024 17:43
@christianrauch christianrauch mentioned this pull request Sep 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧑‍🌾 warnings in ros_image_texture.cpp:477 (all nightly builds)
1 participant
@clalancette