Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Make #4

Open
georgydunaev opened this issue Nov 2, 2018 · 2 comments
Open

Updating Make #4

georgydunaev opened this issue Nov 2, 2018 · 2 comments

Comments

@georgydunaev
Copy link

According to

https://stackoverflow.com/questions/53114522/development-of-the-coq-library-add-loadpath-solution-is-not-good-enough

it is good practice to add "From ZFC " to every "Require Import", rename filename "Make" to "_CoqProject" everywhere, and deleting the first line "-R . ZFC".

By the way, usual name is "zfc", not "ZFC".
I think we may
a)change the name of github repository to "ZFC" (which is more reasonable variant, but something may go wrong, for example for my fork. Or may not.)
b)or change everywhere name to "zfc". "From zfc Require ...". (not very good solution, (a) is better).

@herbelin
Copy link
Contributor

Yes, I prefer (a) too. And adding From ZFC is a good practice.

@Zimmi48
Copy link

Zimmi48 commented Apr 30, 2019

Hi @georgydunaev, I think you have misunderstood @Lysxia's Stack Overflow answer: the first line -R . ZFC is really important, even if you rename Make into _CoqProject. Logical names (i.e. namespaces like ZFC) do not have to be the same as directory name (here zfc) although making them consistent is not a problem either. But even if you do, people will still be able to clone into a directory that would be differently named.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants